fix(deploy): unit-tier test gate in deploy.sh (+ repoint ACR) - #5
Merged
Conversation
scripts/deploy.sh ran 'dotnet test Ravelin.slnx' (whole solution), pulling in the Testcontainers integration + Playwright E2E tiers, which fail on any machine without a Docker daemon and aborted the deploy before the ACR push. Scope the pre-push gate to the unit tier (those tiers run in CI). Also repoint ACR to the current registry after the stack was re-provisioned on a new subscription.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/deploy.shrandotnet test Ravelin.slnx(whole solution), which pulls in the Testcontainers integration tier and the Playwright E2E tier. On any machine without a running Docker daemon those fail, andset -eaborted the deploy before the ACR push (this bit during the subscription migration). Scope the pre-push gate to the fast unit tier — matchingazure-pipelines.ymland the GitHub Actionsbuild-testjob; the Docker/browser tiers run in CI (security.yml).Also repoints
ACR_NAME/ACR_LOGIN_SERVERto the current registry (acrravelindevzxyo1s) after the stack was re-provisioned on a new subscription.Note: the ACR name is still hardcoded (as before); a future improvement would be to read it from
terraform outputso it never drifts per-deploy.