Add topic aliases - #116
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7dde694e6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,155 @@ | |||
| { | |||
| "msmarco-passage.dev-subset": [ | |||
There was a problem hiding this comment.
Use metadata topic ids as alias targets
This aliases file follows the qrels-alias convention of mapping canonical topic ids to alternate ids, but the target key here is not present in _metadata_topics.json (msmarco-passage-dev-subset and msmarco-passage.dev exist instead). A repo check shows 38 of the 42 added targets are absent, including the BEIR .test keys, so any consumer that resolves aliases through the canonical topic metadata will fail or leave these aliases unusable.
Useful? React with 👍 / 👎.
|
CR is good, I need to refactor. |
Parallels
_metadata_qrels_aliases.json.