Preserve BigInt coercion failures - #98
Open
chicoxyzzy wants to merge 1 commit into
Open
Conversation
chicoxyzzy
marked this pull request as ready for review
August 10, 2026 00:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToPrimitiveproperty reads through the same accessor-aware polymorphic lookup as ordinary objectsToBigInt, BigInt/String loose equality, and relational comparisonRoot cause
Function coercion used raw function data-slot reads, which skipped own and inherited accessor descriptors. Separately, BigInt conversion and loose equality read ropes through
flatBytes(), whose safe fallback turns a materialization allocation failure into an empty string; the equality parser also collapsed parser OOM into an ordinary mismatch.Impact
Callable coercion now observes getters and abrupt completions per §7.1.1. BigInt string conversion paths consistently enforce the heap memory ceiling and report allocation failure instead of changing the input or comparison result.
Validation
zig build test-fast --summary all— 3,390 passed, 267 expected skipsToPrimitivefocused suite — 32/32 passedzig build bench -- --filter=loose_eq_bigint_string --runs=1— fixture smoke-tested at 66.62 ms--gc-threshold=1GitHub CI and the bidirectional remote A/B performance screen are in progress while this remains draft.