Repository navigation
Pack only the pointer when packing ndx without a RID - #58
Merged
Merged
Conversation
The .NET 11 SDK, now on the ubuntu-latest runners, also packs the AOT RID packages the host can build when it packs the pointer of a tool. That broke NdxPackTests and would have the publish pointer job upload an ndx.<host-rid> package that collides with the one of the RID matrix. Each RID package is packed on its own with `dotnet pack -r <rid>`, so the pointer pack sets CreateRidSpecificToolPackages=false. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: CodeAlta <noreply@codealta.io>
kzu
enabled auto-merge (rebase)
November 19, 2026 03:29
Member
Author
🧪 Details on Ubuntu 26.04.1 LTSfrom retest v1.1.0 on .NET 11.0.0 with 💜 by @devlooped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build on
mainfails inNdxPackTests.Pack_without_runtime_identifier_is_a_pointer_dotnet_tool: packing without a RID producedndx.linux-x64next to thendxpointer.The cause is the .NET 11 SDK (11.0.100), now preinstalled on
ubuntu-latest. Without aglobal.jsonit wins over the 10.x thatsetup-dotnetinstalls. Since .NET 11, packing the pointer of an AOT tool also packs the RID packages the host can build. Besides the test, this would make the publish pointer job upload anndx.<host-rid>package that collides with the one of the RID matrix.ndx.csprojnow setsCreateRidSpecificToolPackages=falseonly whenRuntimeIdentifieris empty. The pointer still lists every RID package, anddotnet pack -r <rid>is unchanged. Verified locally with SDK 11: a pointer pack yields onlyndx.<ver>.nupkg, and allNdxPackTestspass.🤖 Generated with Claude Code
This pull request was created by CodeAlta.