Skip to content

Pack only the pointer when packing ndx without a RID - #58

Merged
kzu merged 1 commit into
mainfrom
fix/sdk11-pointer-pack
Nov 19, 2026
Merged

kzu merged 1 commit into
mainfrom
fix/sdk11-pointer-pack

Conversation

@kzu

@kzu kzu commented Nov 19, 2026

Copy link
Copy Markdown
Member

The build on main fails in NdxPackTests.Pack_without_runtime_identifier_is_a_pointer_dotnet_tool: packing without a RID produced ndx.linux-x64 next to the ndx pointer.

The cause is the .NET 11 SDK (11.0.100), now preinstalled on ubuntu-latest. Without a global.json it wins over the 10.x that setup-dotnet installs. Since .NET 11, packing the pointer of an AOT tool also packs the RID packages the host can build. Besides the test, this would make the publish pointer job upload an ndx.<host-rid> package that collides with the one of the RID matrix.

ndx.csproj now sets CreateRidSpecificToolPackages=false only when RuntimeIdentifier is empty. The pointer still lists every RID package, and dotnet pack -r <rid> is unchanged. Verified locally with SDK 11: a pointer pack yields only ndx.<ver>.nupkg, and all NdxPackTests pass.

🤖 Generated with Claude Code

This pull request was created by CodeAlta.

The .NET 11 SDK, now on the ubuntu-latest runners, also packs the AOT RID
packages the host can build when it packs the pointer of a tool. That broke
NdxPackTests and would have the publish pointer job upload an ndx.<host-rid>
package that collides with the one of the RID matrix. Each RID package is
packed on its own with `dotnet pack -r <rid>`, so the pointer pack sets
CreateRidSpecificToolPackages=false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: CodeAlta <noreply@codealta.io>
@kzu kzu added the tech debt label Nov 19, 2026
@kzu
kzu enabled auto-merge (rebase) November 19, 2026 03:29
@kzu

kzu commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

248 passed 248 passed

🧪 Details on Ubuntu 26.04.1 LTS

from retest v1.1.0 on .NET 11.0.0 with 💜 by @devlooped

@kzu
kzu merged commit 53b1f47 into main Nov 19, 2026
4 checks passed
@kzu
kzu deleted the fix/sdk11-pointer-pack branch November 19, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant