fix(voice): cap reconnect backoff at maximumConnectDelay - #586
Merged
topi314 merged 1 commit intoAug 10, 2026
Merged
Conversation
topi314
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doReconnect's timer istime.Duration(try) * delayinstead of justdelay. Sincetrynever resets, the actual wait between retries grows linearly forever instead of capping atmaximumConnectDelay(10s) — even though the comment above it says "Exponentially backoff up to a limit of 10s".Confirmed against production logs: by try ~200+, retries were landing ~2000s+ apart (try * 10s), instead of holding steady at 10s.
Fix: use
delaydirectly for the timer.