Fix go vet errors and update mobile decode tests - #18
Open
Qmaker-programmer wants to merge 1 commit into
Open
Conversation
log.Println calls with %v formatting directives never interpolated their arguments; switched to log.Printf. session_test.go passed a slice to a %d verb instead of its length. mobile/decode_test.go still used the pre-fountain-codes header format (blockCode/total), which no longer matches decode.go's expected blockCode/chunkLen/total, causing every test to fail with "invalid header: unexpected EOF". Rewrote the tests to encode/decode through the real Encoder/Decoder round trip instead of hand-crafted headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log.Printlncalls with%vformatting directives never interpolated their arguments (cmd/txqr-tester/app/app.go); switched tolog.Printf.session_test.gopassed a slice to a%dverb instead of its length.mobile/decode_test.gostill used the pre-fountain-codes header format (blockCode/total), which no longer matchesdecode.go's expectedblockCode/chunkLen/total, causing every test to fail withinvalid header: unexpected EOF. Rewrote the tests to encode/decode through the realEncoder/Decoderround trip instead of hand-crafted headers.Test plan
go vet ./...passes cleango test ./...passes (exceptcmd/txqr-tester/app, which requires the GopherJS compiler and is expected to panic under plaingo test)