Fix the compiler ASAN warnings.#30
Open
xiaocj wants to merge 1 commit into
Open
Conversation
MeristemForge
pushed a commit
to MeristemForge/Xylem
that referenced
this pull request
Jun 11, 2026
Vendored minicoro paired start/finish_switch_fiber incorrectly, so ASan computed a bogus negative coroutine stack size and reported false stack-buffer-underflow/unknown-crash on in-bounds coroutine-stack writes (test-mux, test-http), then crashed in its own unwinder before reporting real heap errors -- masking genuine bugs. Apply upstream fix edubart/minicoro#30: track main-thread stack in a thread-local, pair start/finish_switch_fiber across main<->coro and coro<->coro (NULL fake-stack for dead coroutines), skip minicoro's own local-vs-stack overflow check under ASan. ASan now clean on coroutine code: mux/http pass, real rudp heap-use-after-free surfaced. TSan/MSVC unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue #26. The root cause is that __sanitizer_start_switch_fiber() and __sanitizer_finish_switch_fiber() are not paired correctly.