Repository navigation
gdb: Let binary replies reach their query - #1
Merged
Merged
Conversation
Replies are told apart from asynchronous notifications by their first byte, so a binary reply starting with `S`, `T`, `W`, `X` or `O`, such as the result of an `x` memory read, was taken for a stop, exit or console output notification. The query then never got its reply and timed out after 30 seconds, and an `O` could even close the connection. Add `query_with_ordered_predicate()`, whose predicate is consulted ahead of notifications, but only while its request is the oldest one awaiting a reply. Replies arrive in request order, so the packet can only be for that request, which keeps the predicate from claiming replies meant for pipelined requests ahead of it. Existing queries are unaffected. The oldest request is found by iterating the queue, like the rest of the dispatch logic does, as `ArrayQueue.peek()` was observed to disagree with iteration after many removals.
Member
|
Whoah, great catch!! Thanks! 🙌🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replies are told apart from asynchronous notifications by their first byte, so a binary reply starting with
S,T,W,XorO, such as the result of anxmemory read, was taken for a stop, exit or console output notification. The query then never got its reply and timed out after 30 seconds, and anOcould even close the connection.Add
query_with_ordered_predicate(), whose predicate is consulted ahead of notifications, but only while its request is the oldest one awaiting a reply. Replies arrive in request order, so the packet can only be for that request, which keeps the predicate from claiming replies meant for pipelined requests ahead of it. Existing queries are unaffected.The oldest request is found by iterating the queue, like the rest of the dispatch logic does, as
ArrayQueue.peek()was observed to disagree with iteration after many removals.