fix(contrib/drivers/dm): preserve quoted identifiers - #4828
Open
yuyinw wants to merge 1 commit into
Open
Conversation
yuyinw
force-pushed
the
fix/dm-preserve-quoted-identifiers
branch
4 times, most recently
from
August 5, 2026 11:03
266684f to
7caccfb
Compare
yuyinw
force-pushed
the
fix/dm-preserve-quoted-identifiers
branch
from
August 5, 2026 11:18
7caccfb to
0dd607e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the DM driver SQL filter so it preserves double-quoted identifiers, which are used by DM as identifier delimiters.
Previously,
DoFilterremoved all double quotes from SQL, breaking quoted table or column names. This change only removes newline and tab characters while keeping quoted identifiers intact.The DM metadata lookup now first keeps the existing uppercase lookup behavior, then falls back to the original table-name case so quoted, case-sensitive table names can still resolve their fields.
Testing
go test -run 'TestDriverDoFilterPreservesDoubleQuotedIdentifiers|TestTableNameCandidatesForMetadata' -count=1