mnt: mount the auto-provisioned /proc nosuid,nodev,noexec - #283
Open
h1-mrz wants to merge 1 commit into
Open
Conversation
The procfs nsjail auto-mounts (setupMounts) was created without
nosuid/nodev/noexec, so it was mounted dev,suid,exec. Every other
container runtime (runc, Docker, systemd-nspawn) mounts /proc
nosuid,nodev,noexec: there is no legitimate reason for /proc to honor
setuid bits, expose device nodes, or allow execution, and doing so
needlessly widens the in-jail attack surface (e.g. a setuid-root binary
or a device node reachable via a procfs path).
Both mount backends already honor these MountPt fields (mnt_newapi.cc,
mnt_legacy.cc), and the flags remain operator-overridable via an explicit
mount {} config entry.
Verified: /proc inside the jail now shows nosuid,nodev,noexec in
/proc/self/mountinfo (was rw,relatime).
Author
|
Friendly ping on this one :) — it's a small, self-contained hardening change (mounts the auto-provisioned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The procfs nsjail auto-mounts (setupMounts) was created without nosuid/nodev/noexec, so it was mounted dev,suid,exec. Every other container runtime (runc, Docker, systemd-nspawn) mounts /proc nosuid,nodev,noexec: there is no legitimate reason for /proc to honor setuid bits, expose device nodes, or allow execution, and doing so needlessly widens the in-jail attack surface (e.g. a setuid-root binary or a device node reachable via a procfs path).
Both mount backends already honor these MountPt fields (mnt_newapi.cc, mnt_legacy.cc), and the flags remain operator-overridable via an explicit mount {} config entry.
Verified: /proc inside the jail now shows nosuid,nodev,noexec in /proc/self/mountinfo (was rw,relatime).