Skip to content

cmd/gorelease: replace all self versions during load - #84

Open
shivanshgupta365 wants to merge 1 commit into
golang:masterfrom
shivanshgupta365:fix-gorelease-self-replace
Open

cmd/gorelease: replace all self versions during load#84
shivanshgupta365 wants to merge 1 commit into
golang:masterfrom
shivanshgupta365:fix-gorelease-self-replace

Conversation

@shivanshgupta365

@shivanshgupta365 shivanshgupta365 commented Jul 22, 2026

Copy link
Copy Markdown

When a module has a transitive dependency on a higher version of itself,
minimal version selection can ignore the version-scoped replacement added by
prepareLoadDir and load the cached module instead of the local checkout.

Use a wildcard replacement so every selected version resolves to the local
module directory.

Fixes golang/go#80497

@google-cla

google-cla Bot commented Jul 22, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shivanshgupta365
shivanshgupta365 force-pushed the fix-gorelease-self-replace branch from 7d62b2d to e7979db Compare August 3, 2026 11:30
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: e7979db) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/exp/+/809440.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/809440.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/809440.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/exp/cmd/gorelease: circular dependency causes incorrect analysis

2 participants