fix: render download progress during min add - #1213
Draft
gominimal-aw-bot[bot] wants to merge 1 commit into
Draft
Conversation
min never created an ot operation tracker or started its stderr renderer, so the FetchPkg/ExtractPkg operations that rcache already reports while download_if_available fetches and extracts cached packages had nowhere to draw — min add appeared to hang on a static line. mip wires this in run_cli; min's build_config did not. Attach a process-global OpTracker to every Config the package commands build and spawn its renderer once per process, matching mip. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABLow0qA
min adddownloaded packages with no visible progress — the first-time fetch of a package showed only a static line while bytes downloaded and the archive extracted. The instrumentation already existed:rcache::materializereportsFetchPkg/ExtractPkgoperations through anot::OpTracker, andmiprenders that tree to stderr fromrun_cli.minnever created a tracker or started a renderer, soconfig.otwasNoneand those operations drew nowhere. This attaches the same process-global trackermipuses to the sharedbuild_config, spawning the stderr renderer once per process, somin addshows a live progress tree while packages download and materialize. The renderer stays hidden on non-TTY output. (informed by #591)Verification
cargo fmt --all --check — passed
cargo clippy --workspace --locked -- -D warnings — passed, 0 warnings
cargo build --workspace --locked — passed
cargo test --workspace --locked — passed, 84 suites ok, 0 failed
Note
Render download progress to stderr during
min addAttaches an
ot::OpTrackerto the config inbuild_configby callingwith_operation_tracker(operation_tracker()), whereoperation_tracker()lazily initializes a process-global tracker viaOnceLockand startsot::render_to_stderron first use. This causes progress output to appear in stderr when runningmin add.Macroscope summarized 40cbca9.