fix: correct dead links to the removed profiles concept page in docs - #1224
Draft
gominimal-aw-bot[bot] wants to merge 1 commit into
Draft
fix: correct dead links to the removed profiles concept page in docs#1224gominimal-aw-bot[bot] wants to merge 1 commit into
gominimal-aw-bot[bot] wants to merge 1 commit into
Conversation
The profiles concept was removed (superseded by the session config and loadouts), but three concept pages still linked to the deleted profiles.md, rendering as dead links wherever the docs are consumed. Point the packages page at the session concept, since package and env declaration moved from profiles into the [session] block. Drop the profile clauses from the task-sandbox and supply-chain pages, where profiles (and from_profile) no longer apply.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABMz0kDg
The profiles concept page (docs/concepts/profiles.md) was removed when profiles were superseded by the session config and loadouts, but three concept pages still linked to it, so they render as dead links wherever the docs are published. packages.md now points at the session concept, since package and env declaration moved from profiles into the [session] block (informed by #665). sandboxing.md and software-supply-chain.md drop their profile clauses (including from_profile), which no longer describe the current model.
Verification
cargo fmt --all --check --manifest-path target/Cargo.toml — clean, no drift
cargo clippy --workspace --locked --manifest-path target/Cargo.toml -- -D warnings — exit 0, no warnings
cargo build --workspace --locked --manifest-path target/Cargo.toml — exit 0
cargo test --workspace --locked --manifest-path target/Cargo.toml — exit 0, 84 suites passed, 0 failed