[worker:doc-drift] drop phantom hook column from loadout list example - #1238
Conversation
The min loadout list CONTRIBUTES column is built as
"{} pkg / {} var / {} patch" (crates/minimal/src/loadouts.rs:580-585,
598-603); there is no hook segment. Remove the /N hook column from the
docs/concepts/loadouts.md example output so it matches the CLI, and
correct the dev row's var count to 1 to match the single [vars] entry
(EDITOR = "hx") in the example loadout.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Included review availability: 4 reviews are currently available. Based on recent review activity, included reviews refill at 5 per hour. 📝 WalkthroughWalkthroughThe loadout listing documentation example now reports package, variable, and patch counts without lifecycle-hook counts. ChangesLoadout documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation update corrects the loadout example to match the CLI output, with no source or runtime behavior changes. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Issue
Resolves
gominimal/minimal#1231(agent:doc-drift, priority:should-have).The docs/concepts/loadouts.md page documented the
min loadout listoutput with a/ N hooksegment in the CONTRIBUTES column, but the CLI never emits a hook count. The column is built as exactly{} pkg / {} var / {} patch-- no hook segment, and no other code path appends one.Ground truth
crates/minimal/src/loadouts.rs:580-585 (
LoadoutRow::from_entry) and :598-603 (LoadoutRow::builtin_default) build the counts as:The sibling reference doc docs/reference/loadouts.md already renders the column correctly, so this drift was limited to the concepts page.
Fix
Edit the example output block in docs/concepts/loadouts.md (the "Listing your loadouts" section) to drop the
/ N hooksegment from each row so it readsN pkg / N var / N patch, matching the code. Also correct thedevrow's var count to 1 to match the single[vars]entry (EDITOR = "hx") in the example loadout earlier on the page. Documentation-only change; no source touched.Verification
This is a Markdown-only change (docs/concepts/loadouts.md); no .rs file was modified, so the build, clippy, and tests are unaffected. The non-bypassable host backstop still gates
cargo fmt --all --check,cargo build --workspace --all-targets --locked,cargo clippy --workspace --all-targets --locked -- -D warnings, andcargo test --workspace --all-targets --lockedbefore this PR opens.Closes #1231
Summary by CodeRabbit