Repository navigation
or-tools: use the registry's zlib, bzip2, abseil-cpp, protobuf, re2 and boost - #1541
Draft
bryan-minimal wants to merge 1 commit into
Draft
bryan-minimal wants to merge 1 commit into
bryan-minimal wants to merge 1 commit into
Conversation
…nd boost or-tools built and installed its own copies of six libraries the registry already packages, at the same paths with different contents. It now builds against the packages (BUILD_DEPS=OFF) and still builds the solvers and Eigen itself, which the registry does not package. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: not built anywhere yet. The build on this PR is the first test.
Problem
or-tools is built with
BUILD_DEPS=ON, so it compiles and installs its own copy of every dependency. Six of those are packages of this registry, and or-tools' copies land at the same paths with different contents. From the amd64 file lists of pkgs b891179 (every package tarball read, 2026-11-17):That is 8 of the 36 package pairs in the catalog that hold different files at one path. Under the conflict rule of the registry proposal (gominimal/arch#183, model section 12), or-tools could not share a box with any of them. Today the file that is linked first wins, silently.
Change
BUILD_DEPS=OFF, withBUILD_ZLIB,BUILD_BZip2,BUILD_absl,BUILD_Protobuf,BUILD_re2andBUILD_Boostoff: or-tools finds the registry's packages.boostas itslibssubset: soplex uses multiprecision and serialization).build.sh: or-tools built none of the six itself, and none of their files were installed into this package.Risks, all untested
find_packagecalls ask for no version, so it will try; whether it compiles against protobuf 36 and the newer abseil is not known.masterfor its CMake support; the registry's bzip2 is 1.0.8, found through CMake's ownFindBZip2.Not in this PR
🤖 Generated with Claude Code