-
Notifications
You must be signed in to change notification settings - Fork 6
Add zvelte-check-bin 0.2.0 #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| let { Attrs, BuildSpec, Local, OutputBin, Source, .. } = import "minimal.ncl" in | ||
| let { target, .. } = import "config.ncl" in | ||
| let base = import "../base/build.ncl" in | ||
|
|
||
| # Imported from the Homebrew formula `ampcode/homebrew-tap/zvelte-check` by `pkgmgr import homebrew`. | ||
| # | ||
| # PREBUILT vendor binary — there is no source build. The pinned sha256 | ||
| # per architecture is the ONLY integrity anchor for this package. | ||
| let version = "0.2.0" in | ||
| let target_suffix = match { { arch = 'Amd64, .. } => "x86_64", { arch = 'Arm64, .. } => "aarch64" } target in | ||
| { | ||
| name = "zvelte-check-bin", | ||
| build_deps = [ | ||
| { file = "build.sh" } | Local, | ||
| match { | ||
| { arch = 'Amd64, .. } => | ||
| { | ||
| url = "https://github.com/ampcode/zvelte-check/releases/download/v%{version}/zvelte-check-linux-x86_64.tar.gz", | ||
| sha256 = "f3326fe48a0a2bc056b16ce424abd705ca7864d3632fd8f02ace1ea8ecfc8b9b", | ||
| } | Source, | ||
| { arch = 'Arm64, .. } => | ||
| { | ||
| url = "https://github.com/ampcode/zvelte-check/releases/download/v%{version}/zvelte-check-linux-aarch64.tar.gz", | ||
| sha256 = "05a2661648952ba12b2da618242698c3065d2db375340cb605288a38f59c4105", | ||
| } | Source, | ||
| } target, | ||
| base, | ||
| ], | ||
| # No runtime_deps: the installed binary is statically linked | ||
| # (verified against the built tree, not assumed). | ||
|
|
||
| cmd = "./build.sh", | ||
| build_args = { include version, arch = target_suffix }, | ||
|
|
||
| outputs = { | ||
| zvelte-check = { glob = "usr/bin/zvelte-check" } | OutputBin, | ||
| }, | ||
|
|
||
| attrs = | ||
| { | ||
| upstream_version = version, | ||
| license_spdx = "MIT", | ||
| # We install upstream's release BINARIES, not a build of the tree below. | ||
| # `binary_from` is what says so; without it the package reads as | ||
| # source-built from source_provenance, which is the exact conflation that | ||
| # let chromium-bin look like a build of microsoft/playwright. | ||
| binary_from = | ||
| match { | ||
| { arch = 'Amd64, .. } => "https://github.com/ampcode/zvelte-check/releases/download/v%{version}/zvelte-check-linux-x86_64.tar.gz", | ||
| { arch = 'Arm64, .. } => "https://github.com/ampcode/zvelte-check/releases/download/v%{version}/zvelte-check-linux-aarch64.tar.gz", | ||
| } target, | ||
| # Kept alongside `binary_from`, as chromium-bin does. Here the two are the | ||
| # SAME project — ampcode/zvelte-check builds these artifacts in its own | ||
| # release workflow — so the repo is the honest identity of the bytes, and | ||
| # dropping it would cost the CPE identity and the GitHub version-check | ||
| # tier, i.e. make this a dark package. `closed_source` deliberately absent: | ||
| # the repo is public and MIT with the Zig source in-tree (verified, not | ||
| # inferred from the formula). | ||
| source_provenance = { | ||
| category = 'GithubRepo, | ||
| owner = "ampcode", | ||
| repo = "zvelte-check", | ||
| }, | ||
| } | Attrs, | ||
| } | BuildSpec | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,7 @@ | ||||||||||||||||||
| #!/bin/sh | ||||||||||||||||||
| # Imported from the Homebrew formula `ampcode/homebrew-tap/zvelte-check` by `pkgmgr import homebrew`. | ||||||||||||||||||
| # Prebuilt vendor binary: unpacked and installed, never compiled. | ||||||||||||||||||
| set -ex | ||||||||||||||||||
|
Comment on lines
+1
to
+4
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win Use the required Bash strict mode. The build script must start with Proposed fix-#!/bin/sh
+#!/bin/bash
@@
-set -ex
+set -euo pipefail📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsSource: Coding guidelines |
||||||||||||||||||
|
|
||||||||||||||||||
| tar -xof "zvelte-check-linux-${MINIMAL_ARG_ARCH}.tar.gz" | ||||||||||||||||||
| install -D -m 755 "zvelte-check" "$OUTPUT_DIR/usr/bin/zvelte-check" | ||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is truly a binary fetch, drop source provenance and set
binary_from. Also if its closed source you needclosed_source = true.