feat(psmisc): package psmisc version 23.7 by twitchyliquid64 · Pull Request #500 · gominimal/pkgs

twitchyliquid64 · 2026-07-21T18:37:33Z

Because i want killall lol

Summary by CodeRabbit

New Features
- Added the psmisc package, providing system process-management utilities such as killall.
- Included related documentation and localization files.
- Added support for the latest upstream psmisc 23.7 release.
Tests
- Added a validation check to confirm the installed utility reports its version correctly.

coderabbitai · 2026-07-21T18:40:40Z

📝 Walkthrough

Walkthrough

Adds a psmisc package specification pinned to version 23.7, including source retrieval, dependencies, output mappings, metadata, and a killall --version smoke test. The build script configures architecture-specific compilation, ncurses compatibility linking, compilation, and installation.

Changes

psmisc package

Layer / File(s)	Summary
Package definition and outputs `packages/psmisc/build.ncl`	Defines the pinned source archive, runtime dependencies, build command, packaged binaries and documentation, smoke test, provenance, and SPDX license metadata.
Architecture-aware build and installation `packages/psmisc/build.sh`	Enables strict shell execution, selects architecture-specific compiler flags, creates the ncurses compatibility link, configures the build, and installs compiled outputs into `OUTPUT_DIR`.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: bryan-minimal

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: packaging psmisc version 23.7.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch tom/psmisc

_{Comment @coderabbitai help to get the list of available commands.}

bryan-minimal

LGTM

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/psmisc/build.ncl`:
- Around line 49-54: Remove the entire source_provenance block from the package
configuration, including its category, host, owner, and repo fields; do not
replace Gitlab with another provider.

In `@packages/psmisc/build.sh`:
- Around line 9-10: Update the autotools build flow in build.sh to set ARFLAGS
to Drc, include --enable-deterministic-archives in the ./configure invocation,
and remove generated *.la files after installation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 17bf3796-90d9-4841-af6e-dda7ef14618f

📥 Commits

Reviewing files that changed from the base of the PR and between c5d4858 and 78dd82c.

📒 Files selected for processing (2)

packages/psmisc/build.ncl
packages/psmisc/build.sh

coderabbitai · 2026-07-21T18:44:44Z

+    source_provenance = {
+      category = 'Gitlab,
+      host = "gitlab.com",
+      owner = "psmisc",
+      repo = "psmisc",
+    },


🗄️ Data Integrity & Integration | 🔴 Critical | ⚡ Quick win

Use a supported source_provenance category.

Gitlab isn’t a valid source_provenance.category here, so this package will fail schema validation. Remove the block until GitLab provenance is supported; don’t remap it to another provider.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/psmisc/build.ncl` around lines 49 - 54, Remove the entire source_provenance block from the package configuration, including its category, host, owner, and repo fields; do not replace Gitlab with another provider.

coderabbitai · 2026-07-21T18:44:44Z

+export CFLAGS="$MARCH -O2 -pipe -gno-record-gcc-switches -ffile-prefix-map=$(pwd)=/builddir"
+export CXXFLAGS="$CFLAGS"


📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash set -euo pipefail # Map the package files and inspect the build script git ls-files packages/psmisc echo '--- build.sh ---' cat -n packages/psmisc/build.sh echo '--- search for deterministic archive settings in nearby packages ---' rg -n --hidden --glob 'packages/*/build.sh' "ARFLAGS|enable-deterministic-archives|\\.la' -delete|\\.la\" -delete|--enable-deterministic-archives" packages

Repository: gominimal/pkgs

Length of output: 3366

🏁 Script executed:

#!/bin/bash set -euo pipefail # Read only the relevant build script in smaller slices if needed wc -l packages/psmisc/build.sh sed -n '1,120p' packages/psmisc/build.sh

Repository: gominimal/pkgs

Length of output: 964

Add deterministic archive handling for autotools. Set ARFLAGS='Drc', pass --enable-deterministic-archives to ./configure, and remove *.la files after install.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/psmisc/build.sh` around lines 9 - 10, Update the autotools build flow in build.sh to set ARFLAGS to Drc, include --enable-deterministic-archives in the ./configure invocation, and remove generated *.la files after installation.

Source: Coding guidelines

feat(psmisc): package psmisc version 23.7

78dd82c

twitchyliquid64 requested a review from bryan-minimal July 21, 2026 18:37

twitchyliquid64 enabled auto-merge July 21, 2026 18:38

bryan-minimal approved these changes Jul 21, 2026

View reviewed changes

twitchyliquid64 added this pull request to the merge queue Jul 21, 2026

coderabbitai Bot reviewed Jul 21, 2026

View reviewed changes

Merged via the queue into main with commit ae08be2 Jul 21, 2026
10 checks passed

twitchyliquid64 deleted the tom/psmisc branch July 21, 2026 18:45

Navigation Menu

Uh oh!

feat(psmisc): package psmisc version 23.7 - #500

feat(psmisc): package psmisc version 23.7#500
twitchyliquid64 merged 1 commit into
mainfrom
tom/psmisc

twitchyliquid64 commented Jul 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

bryan-minimal left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 21, 2026

Uh oh!

coderabbitai Bot Jul 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		export CFLAGS="$MARCH -O2 -pipe -gno-record-gcc-switches -ffile-prefix-map=$(pwd)=/builddir"
		export CXXFLAGS="$CFLAGS"

Uh oh!

Conversation

twitchyliquid64 commented Jul 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

bryan-minimal left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

twitchyliquid64 commented Jul 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 21, 2026 •

edited

Loading