Add worker support for inline PDF attachment detection and downloading - #10
Open
jaybaird wants to merge 1 commit into
Open
Add worker support for inline PDF attachment detection and downloading#10jaybaird wants to merge 1 commit into
jaybaird wants to merge 1 commit into
Conversation
…sent from Apple Mail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for #9. I recevied an email from someone using Apple Mail that attached an inline PDF. Vireo did not display or detect that there was an attachment in the message. This checks the message for an inline base64 attachment and triggers the attachment download and attachment viewer for these messages.
Displaying inline I think is a non-starter due to https://bugs.webkit.org/show_bug.cgi?id=164423.