ci: pass ECOMMERCE_CHECKOUT_URL through the OCI Playwright test runner - #301
Open
bnsoni wants to merge 1 commit into
Open
ci: pass ECOMMERCE_CHECKOUT_URL through the OCI Playwright test runner#301bnsoni wants to merge 1 commit into
bnsoni wants to merge 1 commit into
Conversation
Journey 55 (free-credits checkout onboarding) reads process.env.ECOMMERCE_CHECKOUT_URL in e2e/fixtures/test-data.ts, but the OCI test runner never forwarded it, so CI runs always fell back to the hardcoded default. Forward the new ECOMMERCE_CHECKOUT_URL Actions variable into .env.oci and the container-instance env, mirroring EXTERNAL_STRIPE_PRICING_URL. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
Claude finished @bnsoni's task —— View job E2E Coverage Review
ResultNo new |
mamigot
approved these changes
Jul 2, 2026
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — No Issues
No new app routes were introduced. All existing coverage is intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ECOMMERCE_CHECKOUT_URLActions variable into the Playwright container env inreusable-oci-test-runner.yml(both the.env.ociwrite and the OCI container-instanceenv-vars.json), mirroring the existingEXTERNAL_STRIPE_PRICING_URLplumbing.e2e/.env.example.Why
Journey 55 (
e2e/journeys/55-free-credits-checkout-onboarding.spec.ts) readsprocess.env.ECOMMERCE_CHECKOUT_URLviae2e/fixtures/test-data.ts, but the test runner never forwarded it, so CI runs always used the hardcoded fallback (http://ibl.ai/join) instead of the stg checkout redirect.The repo Actions variable
ECOMMERCE_CHECKOUT_URLis already set on this repo tohttp://base.manager.stg1.iblai.org/api/service/stripe/checkout/redirect/credits-free-plan.Note: this edits the vendored copy of the reusable — the sibling copies in
iblai/lmsandiblai/iblai-web-opscan be synced separately (the var is mentor-specific, so nothing breaks there meanwhile; unset vars are stripped from the container env and the spec skips itself when the value is empty).🤖 Generated with Claude Code