feat: open search results in a new tab with Shift+Enter / Cmd+Click#4
Merged
Conversation
In the Cmd/Ctrl+K file-search modal, Shift+Enter on the selected result (and Cmd/Ctrl+Click on a result row) now opens the file in a new tab instead of navigating the current one, leaving the modal open so you can fan out to several files. Plain Enter / click keep their same-tab behavior. Adds a "⇧↵ new tab" hint and Playwright coverage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the
Cmd/Ctrl+Kfile-search modal, Shift+Enter on the selected result — and Cmd/Ctrl+Click on a result row — now opens the file in a new tab instead of navigating the current one, and leaves the modal open so you can fan out to several files in one pass. Plain Enter / click keep their same-tab behavior.window.open(path, "_blank")runs synchronously inside the keydown/click handler, so it's a genuine user gesture and won't trip popup blockers. Also adds a⇧↵ new tabhint to the modal for discoverability.Test plan
pnpm build/pnpm exec tsc --noEmit/pnpm lintcleanpnpm test— 78 unit tests passpnpm test:e2e— 22 e2e pass, including new Shift+Enter and Cmd+Click new-tab tests🤖 Generated with Claude Code