fix: use cmd/ctrl+enter to open search result in a new tab#6
Merged
Conversation
Shift+Enter (shipped in the previous change) opened a new *window* rather than a new tab: window.open() reads the live keyboard modifiers, and a held Shift is the OS "new window" convention. Bind the new-tab action to Cmd/Ctrl+Enter instead, mirroring the Cmd/Ctrl+Click affordance on result rows — Cmd/Ctrl maps to "new tab", so window.open() does the right thing with no workaround. Shift+Enter is no longer bound. The modal stays open after opening a tab so you can fan out to several files. Hint updated to a platform-aware "⌘↵ / Ctrl+↵ new tab". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7e39d4d to
074e3b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #4. Shift+Enter on a search result opened a new window instead of a new tab —
window.open()reads the live keyboard modifiers, and a held Shift is the OS "new window" convention (Shift+Click→window).Rather than work around that, bind the new-tab action to Cmd/Ctrl+Enter, mirroring the Cmd/Ctrl+Click affordance on result rows. Cmd/Ctrl maps to "new tab", so
window.open(path, "_blank")does the right thing with no workaround. Shift+Enter is no longer bound. Plain Enter still navigates the current tab. The modal stays open after opening a tab, so you can fan out to several files.Also makes the hint platform-aware (
⌘↵on macOS,Ctrl+↵elsewhere).Test plan
pnpm build/tsc --noEmit/pnpm lintcleanpnpm test:e2e— 22 pass (Cmd+Enter and Cmd+Click new-tab cases)🤖 Generated with Claude Code