Add bindings for ma_device_{get|set}_master_volume and add methods to AbstractDevice#87
Merged
Merged
Conversation
Contributor
Author
|
@irmen Can you please review. |
163413d to
5ca7b3e
Compare
Owner
|
this looks pretty useful, will have a look/test soon |
irmen
requested changes
May 23, 2026
Owner
|
@bradydean do you feel like adding those missing docstrings? |
Contributor
Author
|
They are added now |
Contributor
Author
|
@irmen can you create a release with this? |
Owner
|
grab a wheel in the meantime from the ci build ? https://github.com/irmen/pyminiaudio/actions/runs/26541735611 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds bindings for
ma_device_get_master_volumema_device_set_master_volumeand adds methods to
miniaudio.AbstractDeviceto control the master volume of the device.