Skip to content

Provide default value for requestForTestingPhrase #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hartzell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Provide default value for requestForTestingPhrase #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,7 @@ public static final class DescriptorImpl extends TriggerDescriptor {
* value in the global.jelly file as this value is dynamic and will not be
* retained once configure() is called.
*/
private String requestForTestingPhrase = "Can one of the admins verify this patch?";
private String whitelistPhrase = ".*add\\W+to\\W+whitelist.*";
private String okToTestPhrase = ".*ok\\W+to\\W+test.*";
private String retestPhrase = ".*test\\W+this\\W+please.*";
Expand Down Expand Up @@ -678,8 +679,6 @@ public List<GhprbGitHubAuth> getDefaultAuth(List<GhprbGitHubAuth> githubAuth) {

private String adminlist;

private String requestForTestingPhrase;

// map of jobs (by their fullName) and their map of pull requests
private transient Map<String, Map<Integer, GhprbPullRequest>> jobs;

Expand Down