This repository was archived by the owner on Sep 23, 2021. It is now read-only.
Added support for emojis - #8
Open
laurent22 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of the library strips off emojis from the strings, which is reasonable, but in certain cases emojis are an important part of the original string. This came up for example in this issue as we use the library to convert headers to link IDs and once the emojis are stripped off, it results in empty strings or invalid IDs.
So this pull request adds support for it by converting the emoji to a string, which will now give results like this:
The pull request also adds a test for empty string (just to check that passing an empty string doesn't give any error).