Skip to content
This repository was archived by the owner on Sep 23, 2021. It is now read-only.

Added support for emojis - #8

Open
laurent22 wants to merge 3 commits into
jeremys:masterfrom
laurent22:emoji-support
Open

Added support for emojis#8
laurent22 wants to merge 3 commits into
jeremys:masterfrom
laurent22:emoji-support

Conversation

@laurent22

Copy link
Copy Markdown

The current version of the library strips off emojis from the strings, which is reasonable, but in certain cases emojis are an important part of the original string. This came up for example in this issue as we use the library to convert headers to link IDs and once the emojis are stripped off, it results in empty strings or invalid IDs.

So this pull request adds support for it by converting the emoji to a string, which will now give results like this:

['😁', 'grin'],
['😁a', 'grina'],
['🐶🐶🐶🐱', 'dogdogdogcat'],

The pull request also adds a test for empty string (just to check that passing an empty string doesn't give any error).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant