sentencepiece 依赖修改为 sentencepiece-rs - #50
Open
jackhb1999 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
由于 sentencepiece 为ffi绑定静态库，对于跨平台开发或者是在aha基础上做库开发来讲会引入跨平台调用问题。
本次修改为 sentencepiece 依赖修改为 sentencepiece-rs 。
sentencepiece-rs 作为纯rust库，相关api与sentencepiece 高度类似，但是版本较新，维护较为单薄，是否接纳由 aha 库决定。
另外本次修改只经过 tests/test_moss_tts.rs 功能测试，未进行性能测试。