Skip to content

ci: fix job using cargo clippy instead of cargo check#584

Open
ghost wants to merge 8 commits into
masterfrom
fix-ci-using-clippy-instead-of-check
Open

ci: fix job using cargo clippy instead of cargo check#584
ghost wants to merge 8 commits into
masterfrom
fix-ci-using-clippy-instead-of-check

Conversation

@ghost

@ghost ghost commented Sep 2, 2022

Copy link
Copy Markdown

Closes #290

@ghost ghost requested a review from CohenArthur September 2, 2022 15:37
@Skallwar

Skallwar commented Sep 2, 2022

Copy link
Copy Markdown
Member

I think we should use something like this https://github.com/marketplace/actions/rust-clippy-check

@ghost

ghost commented Sep 5, 2022

Copy link
Copy Markdown
Author

I believe we can trust the action you linked @Skallwar, I'll implement the change later on :) thanks for the tip

@ghost

ghost commented Sep 11, 2022

Copy link
Copy Markdown
Author

@Skallwar actually, the clippy-check action is already being used in our CI in the clippy.yml workflow.
We should probably either drop this file or remove the cargo check from the build_test_fmt.yml workflow.
I do not see any reason why we need both. What's your opinion on this @Skallwar @CohenArthur?

@CohenArthur

Copy link
Copy Markdown
Member

@Skallwar actually, the clippy-check action is already being used in our CI in the clippy.yml workflow. We should probably either drop this file or remove the cargo check from the build_test_fmt.yml workflow. I do not see any reason why we need both. What's your opinion on this @Skallwar @CohenArthur?

My understanding (but I might be wrong) is that the clippy-check action is used to create these nice looking warnings in the pull request window. However, we still want to run cargo clippy to prevent PRs from being merged should they introduce new clippy warnings

@CohenArthur

Copy link
Copy Markdown
Member

(or cargo check)

@ghost ghost force-pushed the fix-ci-using-clippy-instead-of-check branch from 9c819c1 to 0b5c133 Compare September 13, 2022 18:38
Comment thread .github/workflows/build_test_fmt.yml
Comment thread src/typechecker.rs Outdated

@CohenArthur CohenArthur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CI using clippy instead of check

2 participants