Skip to content

Rework users and count endpoints to filter by all provided parameters. - #37579

Closed
Todor13 wants to merge 1 commit into
keycloak:mainfrom
Todor13:issue-36500
Closed

Rework users and count endpoints to filter by all provided parameters.#37579
Todor13 wants to merge 1 commit into
keycloak:mainfrom
Todor13:issue-36500

Conversation

@Todor13

@Todor13 Todor13 commented Feb 22, 2025

Copy link
Copy Markdown
Contributor

Reworked user and count endpoints to filter by all provided criteria, including custom attributes and search term.

Closes #36500

Closes keycloak#36500

Signed-off-by: Todor Staykovski <todorstaykovski@gmail.com>
@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.admin.UserTest#infixSearch

Keycloak CI - Base IT (1)

java.lang.AssertionError: 

Expected: a collection with size <9>
     but: collection size was <10>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

org.keycloak.testsuite.admin.UserTest#prefixSearch

Keycloak CI - Base IT (1)

java.lang.AssertionError: 

Expected: a collection with size <9>
     but: collection size was <10>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@Todor13

Todor13 commented Feb 22, 2025

Copy link
Copy Markdown
Contributor Author

The failing tests indicate that service accounts are included in the proposed PR, since this PR combines the search parameter and the rest of the parameters.
Currently if search parameter is provided, service accounts are excluded, but if not provided and some other attribute is provided the service accounts are included.
Should service accounts be included or excluded from the result?

@ahus1

ahus1 commented Feb 24, 2025

Copy link
Copy Markdown
Member

Pinging @pedroigor as you've been involved in the parent issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

REST API: Get Users: search discards q parameter when used together

4 participants