Rework users and count endpoints to filter by all provided parameters. - #37579
Closed
Todor13 wants to merge 1 commit into
Closed
Rework users and count endpoints to filter by all provided parameters.#37579Todor13 wants to merge 1 commit into
Todor13 wants to merge 1 commit into
Conversation
Closes keycloak#36500 Signed-off-by: Todor Staykovski <todorstaykovski@gmail.com>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.admin.UserTest#infixSearchorg.keycloak.testsuite.admin.UserTest#prefixSearch |
Contributor
Author
|
The failing tests indicate that service accounts are included in the proposed PR, since this PR combines the search parameter and the rest of the parameters. |
Member
|
Pinging @pedroigor as you've been involved in the parent issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked user and count endpoints to filter by all provided criteria, including custom attributes and search term.
Closes #36500