Make Authorization header auth-scheme case-insensitive - #48406
Closed
alimmirk wants to merge 4 commits into
Closed
Conversation
…itive Signed-off-by: alimmirk <alim.95@yandex.ru>
alimmirk
force-pushed
the
fix-auth-scheme-case-insensitivity
branch
from
April 23, 2026 11:57
a7f5651 to
f724cde
Compare
stianst
requested changes
Apr 30, 2026
stianst
left a comment
Contributor
There was a problem hiding this comment.
I agree with supporting case-insensitive headers, but this PR also adds support for case-insensitive token types, which is not needed as the tokens are generated by KC so we know what case they will use. So please remove those changes and focus on what is mentioned in the linked issue.
There is also no tests added here.
Author
|
Closing this PR as the required case-insensitivity changes for the Authorization header have already been integrated into main, and the internal token type checks should remain case-sensitive as requested by @stianst. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48387
This PR makes the 'Bearer' and 'DPoP' auth schemes in the Authorization header case-insensitive, as required by RFC 9110, Section 11.1. Previously, Keycloak was strictly case-sensitive for these schemes (especially DPoP).