Skip to content

[OID4VCI] Update conformance test to 5.1.45 - #50404

Closed
VinodAnandan wants to merge 1 commit into
keycloak:mainfrom
VinodAnandan:main
Closed

[OID4VCI] Update conformance test to 5.1.45#50404
VinodAnandan wants to merge 1 commit into
keycloak:mainfrom
VinodAnandan:main

Conversation

@VinodAnandan

Copy link
Copy Markdown
Contributor

Closes #50403

Copilot AI review requested due to automatic review settings June 28, 2026 18:08
@VinodAnandan
VinodAnandan requested a review from a team as a code owner June 28, 2026 18:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the OpenID conformance test suite container image tag used by Keycloak’s conformance test module to align with the upstream conformance-suite release v5.1.45 (per #50403).

Changes:

  • Bump the default conformance-suite Docker image tag from release-v5.1.44 to release-v5.1.45 in the test container bootstrap code.
  • Bump the Maven keycloak.conformance.imageTag property to release-v5.1.45 so the default is consistent when running via Maven/Surefire.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/conformance/src/test/java/org/keycloak/tests/conformance/containers/OpenIdConformanceSuite.java Updates the fallback default image tag to release-v5.1.45 for non-Maven runs.
tests/conformance/pom.xml Updates the Maven property passed into tests so Maven runs use release-v5.1.45.

@VinodAnandan
VinodAnandan marked this pull request as draft June 29, 2026 08:01
@VinodAnandan
VinodAnandan marked this pull request as ready for review June 29, 2026 08:01

@wistefan wistefan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copilot AI review requested due to automatic review settings June 29, 2026 09:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Signed-off-by: Vinod Anandan <vinodanandan@Vinods-MacBook-Pro.local>
Copilot AI review requested due to automatic review settings July 1, 2026 10:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@VinodAnandan

Copy link
Copy Markdown
Contributor Author

I'm cancelling this in favour of this PR: #50577.

Thanks, @dominikschlosser !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update conformance test to 5.1.45

4 participants