fix: ensuring truststore initialization happens before factory init - #51405
Merged
Conversation
closes: keycloak#51396 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Pepo48
reviewed
Aug 4, 2026
Pepo48
left a comment
Contributor
There was a problem hiding this comment.
The core fix looks correct, one issue with the test assertion though - String.matches() returns a boolean that's never asserted on, so the test passes regardless (even with nonsensical string).
| .get("https://mykeycloak.org:8443").then().body(Matchers.containsString("https://mykeycloak.org")); | ||
|
|
||
| // ensure that the provider factories init with the correct truststore | ||
| result.getOutput().matches("File truststore provider initialized: [^\\n]*keycloak-truststore.p12"); |
Contributor
There was a problem hiding this comment.
Suggested change
| result.getOutput().matches("File truststore provider initialized: [^\\n]*keycloak-truststore.p12"); | |
| result.assertStringCount("File truststore provider initialized: [^\\n]*keycloak-truststore\\.p12", 1); |
michalvavrik
approved these changes
Aug 4, 2026
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPUserLoginTest#loginLDAPUserCredentialVaultAuthenticationSimpleEncryptionStartTLSKeycloak CI - Java Distribution IT (windows-latest - temurin - 17) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #51396