Ensure consistent transaction rollback in SCIM error response paths - #51429
Merged
Conversation
Closes keycloak#51428 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures all centralized SCIM error responses mark the active transaction for rollback, preventing partial state persistence.
Changes:
- Moves rollback marking before exception-specific response handling.
- Applies rollback consistently across all SCIM error paths.
Member
Author
|
@pedroigor @sguilhen Hi! Could you please check it? Thanks! |
ahus1
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@keycloak/core-iam-maintainers Could you please check it? Thanks!