Complete Identity Provider DSL support in test framework by polifr · Pull Request #51436 · keycloak/keycloak

polifr · 2026-08-04T20:50:52Z

This PR completes the Identity Provider DSL in the Keycloak Test Framework.

It includes:

additional configuration methods in IdentityProviderBuilder for properties already available in IdentityProviderRepresentation but not mapped in the builder
a new IdentityProviderMapperBuilder for IdentityProviderMapperRepresentation building
a RealmBuilder overload accepting IdentityProviderMapperBuilder instances

The changes allow complete broker configurations to be expressed using the fluent Realm DSL without directly manipulating representation classes.

Closes #51359

Copilot

Pull request overview

Completes the test-framework DSL for configuring identity providers and their mappers.

Changes:

Adds identity-provider configuration methods.
Introduces IdentityProviderMapperBuilder.
Adds mapper-builder support to RealmBuilder.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`RealmBuilder.java`	Accepts identity-provider mapper builders.
`IdentityProviderMapperBuilder.java`	Adds fluent mapper construction.
`IdentityProviderBuilder.java`	Adds identity-provider configuration options.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

test-framework/builders/src/main/java/org/keycloak/testframework/realm/IdentityProviderMapperBuilder.java:15

The new fluent mapper path has no unit coverage, although this module's BuilderTest covers similar builder composition. Add a test that sets every mapper field/config entry, passes the builder to RealmBuilder.identityProviderMappers(...), and asserts the resulting nested representation so this new DSL contract is protected.

    public static IdentityProviderMapperBuilder create() {
        return new IdentityProviderMapperBuilder(new IdentityProviderMapperRepresentation());
    }

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

vaceksimon

Thanks for the contribution @polifr!

Please fix the spotless issue causing the CI failure, you can follow the CONTRIBUTING.md guide:

keycloak/CONTRIBUTING.md

Lines 126 to 151 in e8baed0

    
           ### Spotless 
        
           Spotless is used to check and apply code formatting. To check your code locally before sending a PR run: 
        
           ``` 
        
           ./mvnw spotless:check 
        
           ``` 
        
           You can either use your IDE to fix these issues; or Spotless can fix them for you by running: 
        
           ``` 
        
           ./mvnw spotless:apply 
        
           ``` 
        
           A good practice is to create a commit with your changes prior to running `spotless:apply` then you can see and 
        
           review what changes Spotless has applied, for example by using a diff tool. Finally, if you are happy with the changes 
        
           Spotless has applied you can amend the changes to your commit by running: 
        
           ``` 
        
           git add -a 
        
           git commit --amend 
        
           ``` 
        
           Note: If you get the error `Could not find goal 'verify' in plugin com.diffplug.spotless:spotless-maven-plugin` you are 
        
           probably running `mvn spotless:check` instead of `./mvnw spotless:check`. This is most likely a bug in Maven or the  
        
           Spotless plugin.

You can also ignore the Copilot's request for a test, it is not necessary for a builder. The test class can be removed.

Add missing builder methods to IdentityProviderBuilder and introduce IdentityProviderMapperBuilder to provide a fluent API consistent with the rest of the RealmBuilder DSL. Closes keycloak#51359 Signed-off-by: Francesco Poli <polifr@gmail.com>

Signed-off-by: Francesco Poli <polifr@gmail.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

vaceksimon · 2026-08-06T08:19:24Z

Hey @ahus1, can you please re-run the failed jobs? They don't seem to be related to this PR's changes

vaceksimon

Thanks @polifr, LGTM

ahus1 · 2026-08-06T10:01:59Z

@vaceksimon - quite a lot of jobs failed; let's hope for the best.

Copilot AI balanced review requested due to automatic review settings August 4, 2026 20:50

polifr requested a review from a team as a code owner August 4, 2026 20:50

Copilot started reviewing on behalf of polifr August 4, 2026 20:51 View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

Comment thread ...k/builders/src/main/java/org/keycloak/testframework/realm/IdentityProviderMapperBuilder.java

Comment thread ...amework/builders/src/main/java/org/keycloak/testframework/realm/IdentityProviderBuilder.java Outdated

Copilot AI review requested due to automatic review settings August 4, 2026 21:04

Copilot started reviewing on behalf of polifr August 4, 2026 21:04 View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings August 4, 2026 21:44

Copilot started reviewing on behalf of polifr August 4, 2026 21:45 View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

ahus1 requested review from lhanusov and vaceksimon August 5, 2026 07:36

vaceksimon reviewed Aug 5, 2026

View reviewed changes

vaceksimon added the area/test-framework label Aug 5, 2026

Copilot AI review requested due to automatic review settings August 5, 2026 20:44

Copilot started reviewing on behalf of polifr August 5, 2026 20:45 View session

polifr added 4 commits August 5, 2026 22:47

type fluent method removed, as suggested by reviewer

37aafba

Signed-off-by: Francesco Poli <polifr@gmail.com>

Test for coverage of the overloaded identityProviderMappers method

35f4659

Signed-off-by: Francesco Poli <polifr@gmail.com>

Import order fixed by spotless

40931bb

Signed-off-by: Francesco Poli <polifr@gmail.com>

Copilot AI reviewed Aug 5, 2026

View reviewed changes

polifr force-pushed the test-framework-builders-enhancement branch from 783f628 to 40931bb Compare August 5, 2026 20:47

vaceksimon approved these changes Aug 6, 2026

View reviewed changes

ahus1 approved these changes Aug 6, 2026

View reviewed changes

ahus1 enabled auto-merge (squash) August 6, 2026 10:19

ahus1 merged commit 38e0c10 into keycloak:main Aug 6, 2026
147 of 151 checks passed

polifr deleted the test-framework-builders-enhancement branch August 7, 2026 08:34

Navigation Menu

Uh oh!

Complete Identity Provider DSL support in test framework - #51436

Complete Identity Provider DSL support in test framework#51436
ahus1 merged 4 commits into
keycloak:mainfrom
polifr:test-framework-builders-enhancement

polifr commented Aug 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

vaceksimon left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

vaceksimon commented Aug 6, 2026

Uh oh!

vaceksimon left a comment

Uh oh!

ahus1 commented Aug 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	### Spotless

	Spotless is used to check and apply code formatting. To check your code locally before sending a PR run:

	```
	./mvnw spotless:check
	```

	You can either use your IDE to fix these issues; or Spotless can fix them for you by running:

	```
	./mvnw spotless:apply
	```

	A good practice is to create a commit with your changes prior to running `spotless:apply` then you can see and
	review what changes Spotless has applied, for example by using a diff tool. Finally, if you are happy with the changes
	Spotless has applied you can amend the changes to your commit by running:

	```
	git add -a
	git commit --amend
	```

	Note: If you get the error `Could not find goal 'verify' in plugin com.diffplug.spotless:spotless-maven-plugin` you are
	probably running `mvn spotless:check` instead of `./mvnw spotless:check`. This is most likely a bug in Maven or the
	Spotless plugin.

Uh oh!

Conversation

polifr commented Aug 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

vaceksimon left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

vaceksimon commented Aug 6, 2026

Uh oh!

vaceksimon left a comment

Choose a reason for hiding this comment

Uh oh!

ahus1 commented Aug 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants