Enable signature validation when metadata KeyDescriptor has no use at… - #51503
Merged
pedroigor merged 1 commit intoAug 10, 2026
Merged
Conversation
…tribute Closes keycloak#51471 Closes CVE-2026-16443 Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes SAML metadata import so certificates without a use attribute enable response signature validation.
Changes:
- Enables signature validation for fallback certificates.
- Adds regression coverage for metadata without key usage attributes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
services/.../SAMLIdentityProviderFactory.java |
Enables validation for fallback signing certificates. |
testsuite/.../KcSamlParseIdPDescriptorTest.java |
Tests import behavior without use="signing". |
pedroigor
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tribute
Closes #51471
Closes CVE-2026-16443