fix unstyled button in account already exisited page - #51521
Merged
Conversation
mabartos
self-requested a review
August 6, 2026 15:41
Closes keycloak#51330 Signed-off-by: Yike Gao <yikegao8@gmail.com>
gaoyikeshuer
force-pushed
the
account-exist-ui-bug-51330
branch
from
August 7, 2026 09:45
a44869c to
be2df11
Compare
Contributor
Author
|
Root cause is the v2 theme doesn't have login-idp-link-confirm.ftl, so it used the base version, whose kcButtonDefaultClass/kcButtonLargeClass don't exist in v2. so copied the login-idp-link-confirm.ftl from v1 with the v2 button styles |
Member
|
@gaoyikeshuer I'll check this more deeper, but LGTM from the first sight. Do we know about some other pages that might be affected by the defaulting to the base theme with some potential issues? Would be good to confirm it. Thanks! |
edewit
approved these changes
Aug 10, 2026
rmartinc
approved these changes
Aug 10, 2026
rmartinc
left a comment
Contributor
There was a problem hiding this comment.
Thanks everybody! LGTM too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after fix
Closes #51330