Skip to content

Add ownership validation for issued verifiable credentials - #51524

Closed
jimmychakkalakal wants to merge 1 commit into
keycloak:mainfrom
jimmychakkalakal:weakness/50368-OID4VCI-Missing_Ownership_Validation
Closed

Add ownership validation for issued verifiable credentials#51524
jimmychakkalakal wants to merge 1 commit into
keycloak:mainfrom
jimmychakkalakal:weakness/50368-OID4VCI-Missing_Ownership_Validation

Conversation

@jimmychakkalakal

Copy link
Copy Markdown
Contributor

Closes #50368

Closes keycloak#50368

Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com>
@keycloak-github-bot

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testExceedMaxTemporaryLockouts

Keycloak CI - Base IT (5)

org.opentest4j.AssertionFailedError: Expected error event ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@VinodAnandan

Copy link
Copy Markdown
Contributor

Hey @jimmychakkalakal, I think this may be a duplicate effort. There’s another open PR addressing the same issue: #51418. Not sure if you’ve seen this one already ?

@jimmychakkalakal

Copy link
Copy Markdown
Contributor Author

Hey @VinodAnandan Thanks, for pointing out. I didn't notice it before

@jimmychakkalakal

Copy link
Copy Markdown
Contributor Author

PR unnecessary, Issue resolved in #51418
Closing PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OID4VCI: Account API delete endpoint for issued verifiable credentials missing ownership validation

2 participants