Add event detail when using rotated password to authenticate the client - #51545
Open
rmartinc wants to merge 2 commits into
Open
Add event detail when using rotated password to authenticate the client#51545rmartinc wants to merge 2 commits into
rmartinc wants to merge 2 commits into
Conversation
Closes keycloak#51528 Signed-off-by: rmartinc <rmartinc@redhat.com>
Closes keycloak#51528 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds event metadata identifying authentication with rotated client secrets across standard and JWT client authentication.
Changes:
- Adds
client_auth_detail=rotated_secretto relevant events. - Adds coverage for primary and rotated secrets.
- Migrates and shares client-secret rotation test utilities.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
testsuite/.../ClientAuthSecretSignedJWTTest.java |
Removes legacy test. |
tests/base/.../ClientAuthSecretSignedJWTTest.java |
Migrates and extends JWT tests. |
tests/base/.../ClientSecretRotationUtils.java |
Adds shared rotation utilities. |
tests/base/.../ClientSecretRotationTest.java |
Verifies event details. |
services/.../JWTClientSecretAuthenticator.java |
Records rotated JWT secret usage. |
services/.../ClientIdAndSecretAuthenticator.java |
Records rotated secret usage. |
server-spi-private/.../ClientSecretConstants.java |
Defines rotated-detail value. |
server-spi-private/.../Details.java |
Defines event-detail key. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51528
Adding a new detail for the client authentication when the rotated secret is used. I also migrated the
ClientAuthSecretSignedJWTTestclass.