Enforce user-profile view permissions for SCIM reads and filters - #51548
Open
sguilhen wants to merge 1 commit into
Open
Enforce user-profile view permissions for SCIM reads and filters#51548sguilhen wants to merge 1 commit into
sguilhen wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enforces user-profile visibility permissions for SCIM reads and filters.
Changes:
- Filters SCIM schema attributes by profile permissions.
- Updates existing SCIM tests for user-visible attributes.
- Adds read and filter authorization coverage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
AbstractScimTest.java |
Makes shared test attributes user-visible. |
AuthorizationTest.java |
Adds permission regression tests. |
UserTest.java |
Updates searchable custom-attribute permissions. |
AbstractUserModelSchema.java |
Filters core schema mappings by visibility. |
UserExtensionModelSchema.java |
Filters extension mappings by visibility. |
sguilhen
force-pushed
the
50987-scim-user-profile-view-bypass
branch
from
August 7, 2026 20:14
df76d84 to
ae33693
Compare
sguilhen
force-pushed
the
50987-scim-user-profile-view-bypass
branch
from
August 7, 2026 21:08
ae33693 to
d25d4b6
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLClockSkewAdapterTest#testTokenTimeIsValidKeycloak CI - Adapter IT Strict Cookies |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
scim/model/src/main/java/org/keycloak/scim/model/user/AbstractUserModelSchema.java:39
- The new authorization regression maps only extension attributes, so it exercises
UserExtensionModelSchemabut not this core-schema resolver path. Add a core-mapped attribute with admin-only view permission and verify both reads and filters cannot access it.
Set<String> names = new HashSet<>(profile.getAttributes().getReadable().keySet());
Closes keycloak#50987 Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
sguilhen
force-pushed
the
50987-scim-user-profile-view-bypass
branch
from
August 8, 2026 00:49
d25d4b6 to
a1b29c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50987