SSF: Fix NPE in transmitter on RP-initiated logout without details (#51571) - #51572
Open
thomasdarimont wants to merge 1 commit into
Open
SSF: Fix NPE in transmitter on RP-initiated logout without details (#51571)#51572thomasdarimont wants to merge 1 commit into
thomasdarimont wants to merge 1 commit into
Conversation
…eycloak#51571) The non-browser RP-initiated logout path emits a success LOGOUT event without any details when no post_logout_redirect_uri is given, so Event.getDetails() is null. SecurityEventTokenMapper.shouldIgnoreLogout and SsfTransmitterEventListener.isUserSessionExpiration dereferenced the details map unconditionally, crashing the SSF event listener. Treat missing details as a real logout / non-expiration. Fixes keycloak#51571 Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes SSF listener null dereferences when logout or session-deletion events have no details.
Changes:
- Safely handles null event details.
- Preserves real logout propagation.
- Adds regression tests for affected paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
SsfTransmitterEventListener.java |
Handles missing session-deletion details. |
SecurityEventTokenMapper.java |
Handles missing logout details. |
SsfTransmitterEventListenerTest.java |
Tests null session-deletion details. |
SecurityEventTokenMapperTest.java |
Tests logout filtering with null and populated details. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.WebAuthnPropertyTest#timeout |
Contributor
Author
|
I recommend to add this to a 26.7.2 patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-browser RP-initiated logout path emits a success LOGOUT event without any details when no post_logout_redirect_uri is given, so Event.getDetails() is null. SecurityEventTokenMapper.shouldIgnoreLogout and SsfTransmitterEventListener.isUserSessionExpiration dereferenced the details map unconditionally, crashing the SSF event listener. Treat missing details as a real logout / non-expiration.
Fixes #51571