adding javadocs to the MisdirectedFilter - #51588
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Javadocs explaining the security purpose and behavior of MisdirectedFilter.
Changes:
- Documents HTTP/2 connection coalescing risks.
- Describes pass-through cases and HTTP 421 handling.
Suppressed comments (1)
quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/services/MisdirectedFilter.java:36
- Correct the spelling of “noticable” to “noticeable.”
* is running. If this causes a noticable performance regression in these scenarios,
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closes keycloak#50602 Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/services/MisdirectedFilter.java:20
- This activation description omits two registration gates and equates having no proxy headers with TLS passthrough.
KeycloakRecorder.misdirectedRequestFilterregisters the filter only when HTTPS and SNI are enabled and proxy headers are unset; direct HTTPS can also meet those conditions (KeycloakRecorder.java:147-156).
* <p>Only active in TLS passthrough mode (no proxy headers configured). Registered by
* {@link org.keycloak.quarkus.runtime.KeycloakRecorder#misdirectedRequestFilter}.
michalvavrik
approved these changes
Aug 11, 2026
ruchikajha95
pushed a commit
to ruchikajha95/keycloak
that referenced
this pull request
Aug 12, 2026
Closes keycloak#50602 Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net> Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50602
Separated from #51443 and associated directly with the prior issue.