Skip to content

fix: renaming the admin client tests module for use by the operator - #51675

Open
shawkins wants to merge 1 commit into
keycloak:mainfrom
shawkins:iss50598
Open

fix: renaming the admin client tests module for use by the operator#51675
shawkins wants to merge 1 commit into
keycloak:mainfrom
shawkins:iss50598

Conversation

@shawkins

@shawkins shawkins commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

closes: #50598

@shawkins
fix: renaming the admin client tests module for use by the operator
0754420 
closes: keycloak#50598

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Aug 12, 2026
View reviewed changes

@keycloak-github-bot keycloak-github-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot

keycloak-github-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPUserLoginTest#loginLDAPUserAuthenticationSimpleEncryptionStartTLS

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

org.openqa.selenium.TimeoutException: 
java.net.SocketTimeoutException: Read timed out
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Windows Server 2025', os.arch: 'amd64', os.version: '10.0', java.version: '17.0.20'
Driver info: driver.version: HtmlUnitDriver
...

Report flaky test

@shawkins
shawkins marked this pull request as ready for review August 12, 2026 13:58
@shawkins
shawkins requested review from a team as code owners August 12, 2026 13:58
Copilot AI balanced review requested due to automatic review settings August 12, 2026 13:58
Copilot AI reviewed Aug 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the internal admin client artifact and enables the operator to use the project-aligned implementation.

Changes:

  • Renames keycloak-admin-client-tests to keycloak-admin-client-internal.
  • Updates all dependencies and exclusions.
  • Migrates the operator to the internal client and RESTEasy builder API.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pom.xml Updates dependency management.
integration/admin-client/pom.xml Renames and redescribes the artifact.
operator/pom.xml Uses the internal client as a production dependency.
operator/src/main/java/org/keycloak/operator/controllers/KeycloakClientBaseController.java Uses the RESTEasy provider directly.
distribution/api-docs-dist/pom.xml Updates the documentation distribution dependency.
test-framework/core/pom.xml Updates the test framework dependency.
testsuite/utils/pom.xml Updates the testsuite utility dependency.
testsuite/integration-arquillian/tests/pom.xml Updates the Arquillian dependency.
tests/utils/pom.xml Updates the test utility dependency.
tests/utils-shared/pom.xml Updates the shared utility dependency.
tests/conformance/pom.xml Updates the conformance-test dependency.
tests/base/pom.xml Updates Jackson 3 profile exclusions.
rest/admin-v2/tests/pom.xml Updates Jackson 3 profile exclusions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Pepo48
Pepo48 approved these changes Aug 12, 2026
View reviewed changes

@Pepo48 Pepo48 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Steve.

michalvavrik
michalvavrik approved these changes Aug 13, 2026
View reviewed changes

@michalvavrik michalvavrik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Keycloak Client will be affected though and we need a PR for their repo, which is going to conflict with keycloak/keycloak-client#233 or I need to update it in there

@shawkins
shawkins requested a review from mposolda August 13, 2026 16:04
vmuzikar
vmuzikar approved these changes Aug 13, 2026
View reviewed changes

@vmuzikar vmuzikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@vmuzikar

vmuzikar commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Not merging yet, waiting for @mposolda's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@Pepo48 Pepo48 Pepo48 approved these changes
@vmuzikar vmuzikar vmuzikar approved these changes
@mposolda mposolda Awaiting requested review from mposolda
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@michalvavrik michalvavrik michalvavrik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow keycloak-admin-client-tests for internal usage

5 participants

@shawkins @vmuzikar @Pepo48 @michalvavrik