is-51676 alter emailExistsMessage message - #51677
Conversation
2df0820 to
5cbf595
Compare
There was a problem hiding this comment.
Pull request overview
Updates emailExistsMessage to distinguish login and account contexts.
Changes:
- Adds context-specific messages for login and account themes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
themes/src/main/resources/theme/base/login/messages/messages_en.properties |
Updates the login-theme message. |
themes/src/main/resources/theme/base/account/messages/messages_en.properties |
Updates the account-theme message. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
5cbf595 to
f25e551
Compare
f25e551 to
c13d6bd
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
Suppressed comments (1)
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/federation/ldap/LDAPProvidersIntegrationTest.java:1000
- Updating this LDAP login assertion leaves
registerExistingLdapUser()at line 701 expecting the old text. That test also rendersemailExistsMessagethrough the login theme, so it will now fail and its assertion must be updated too.
Assertions.assertEquals("This email is already associated with an existing account.", loginPage.getError());
stianst
left a comment
There was a problem hiding this comment.
Email already exists is not ideal, but i don't see why the message should be different in the login and the account themes. You're basically just stating the same thing, just with slightly different words after all.
|
Obviously you are right. I came across this, some weeks ago, when a customer was complaining, that the Error Message in the Login UI (register) was misleading in German.
@ahus1 asked me if it would make sense to change the English messages accordingly. So I thought about what the context for each scenario is. Im fine if you would like to keep the messages in sync. Then I will change my PR accordingly. |
|
I'd just go with |
Signed-off-by: Robin Meese <39960884+robson90@users.noreply.github.com>
c13d6bd to
e67f1ef
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
Suppressed comments (1)
themes/src/main/resources/theme/base/account/messages/messages_en.properties:212
- Issue #51676 requires the account context to say “An account with this email address is already registered.” while reserving this wording for login. Using the login text here leaves both contexts identical, so the requested distinction is not implemented.
emailExistsMessage=This email is already associated with an existing account.
|
Thanks for the feedback, as far as I can tell all messages have been migrated. The failing FIPS IT comes from a 403: |
Closes: #51676