Test cases migration: userSessionLimits - #51231
Draft
ruchikajha95 wants to merge 5 commits into
Draft
Conversation
ruchikajha95
force-pushed
the
feature-47811/sessionlimits-package
branch
3 times, most recently
from
July 30, 2026 09:10
c2c7044 to
ce0c08c
Compare
ruchikajha95
force-pushed
the
feature-47811/sessionlimits-package
branch
2 times, most recently
from
August 4, 2026 15:48
4ae0f3f to
ee06995
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.federation.ldap.LDAPUserLoginTest#loginLDAPUserCredentialVaultAuthenticationSimpleEncryptionStartTLSKeycloak CI - Java Distribution IT (windows-latest - temurin - 17) |
ruchikajha95
force-pushed
the
feature-47811/sessionlimits-package
branch
from
August 5, 2026 10:37
1007814 to
d03f5fd
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.registration.AuthAttachmentRegisterTest#authenticatorAttachmentPlatform |
ruchikajha95
force-pushed
the
feature-47811/sessionlimits-package
branch
from
August 6, 2026 09:43
4e318fa to
6377907
Compare
Closes keycloak#47811 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#47811 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#47811 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#47811 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
ruchikajha95
force-pushed
the
feature-47811/sessionlimits-package
branch
from
August 6, 2026 18:55
693d7cb to
d99b189
Compare
ruchikajha95
requested review from
ahus1,
pruivo and
ryanemerson
and
a balanced review from Copilot
August 7, 2026 08:45
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates user-session-limit broker tests from the legacy Arquillian suite to the new test framework.
Changes:
- Adds OIDC and SAML broker session-limit tests and shared flow utilities.
- Adds an IdP profile-review page object with configurable page-wait timeout.
- Removes migrated tests from the legacy suite.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
testsuite/.../volatile-sessions-suite |
Removes obsolete exclusions. |
testsuite/.../clusterless-suite |
Removes obsolete exclusions. |
testsuite/.../base-suite |
Removes the migrated package. |
testsuite/.../sessionlimits/UserSessionLimitsUtil.java |
Removes legacy utility. |
testsuite/.../sessionlimits/KcSamlUserSessionLimitsBrokerTest.java |
Removes legacy SAML test. |
testsuite/.../sessionlimits/KcOidcUserSessionLimitsBrokerTest.java |
Removes legacy OIDC test. |
testsuite/.../sessionlimits/AbstractUserSessionLimitsBrokerTest.java |
Removes legacy shared test base. |
tests/base/.../sessionlimits/UserSessionLimitsUtil.java |
Adds post-broker flow helpers. |
tests/base/.../sessionlimits/KcSamlUserSessionLimitsBrokerTest.java |
Adds migrated SAML coverage. |
tests/base/.../sessionlimits/KcOidcUserSessionLimitsBrokerTest.java |
Adds migrated OIDC coverage. |
test-framework/ui/.../WaitUtils.java |
Supports custom page-wait timeouts. |
test-framework/ui/.../IdpReviewUserProfilePage.java |
Models the IdP profile-review page. |
msdaly200
reviewed
Aug 7, 2026
msdaly200
reviewed
Aug 7, 2026
msdaly200
reviewed
Aug 7, 2026
Contributor
Author
|
Thanks for the review @msdaly200 ! i will push the changes asap. |
Closes keycloak#47811 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
pruivo
reviewed
Aug 10, 2026
|
|
||
| import org.keycloak.testframework.ui.webdriver.ManagedWebDriver; | ||
|
|
||
| public class IdpReviewUserProfilePage extends LoginUpdateProfilePage { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers the migration of the test cases from old test suits to the new test suit.
The focus was to migrate the userSessionLimits : https://github.com/keycloak/keycloak/tree/main/testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/sessionlimits
Closes #47811
Signed-off-by: Ruchika ruchika.jha1@ibm.com