Skip to content

[26.6] moving waiting into the assertMessage method - #51239

Merged
vmuzikar merged 2 commits into
keycloak:release/26.6from
shawkins:iss51070-26.6
Aug 6, 2026
Merged

[26.6] moving waiting into the assertMessage method#51239
vmuzikar merged 2 commits into
keycloak:release/26.6from
shawkins:iss51070-26.6

Conversation

@shawkins

Copy link
Copy Markdown
Contributor

also making output reading more fool-proof

close: #51070

also making output reading more fool-proof

close: keycloak#51070

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins marked this pull request as ready for review July 28, 2026 19:45
@shawkins
shawkins requested review from a team as code owners July 28, 2026 19:45
@shawkins shawkins changed the title fix: moving waiting into the assertMessage method [26.6] moving waiting into the assertMessage method Jul 28, 2026

@Pepo48 Pepo48 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor clean-up.

I also think that that outer Awaitility.await() in JaxRsDistTest is now redundant as well and we can clean it up. Probably relevant for main/#51238 too.

@shawkins

Copy link
Copy Markdown
Contributor Author

I also think that that outer Awaitility.await() in JaxRsDistTest is now redundant as well and we can clean it up. Probably relevant for main/#51238 too.

Yes it is now redundant. Added that to the other PR.

Applied your suggested edits as well.

@Pepo48 Pepo48 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks, Steve!

Co-authored-by: Peter Zaoral <pepo48@gmail.com>
Signed-off-by: Steven Hawkins <shawkins@redhat.com>
@vmuzikar
vmuzikar enabled auto-merge (squash) August 3, 2026 12:24
@vmuzikar
vmuzikar merged commit 8df73c6 into keycloak:release/26.6 Aug 6, 2026
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants