Skip to content

Incorrect exact comparison when higher loa should be allowed - #51392

Merged
rmartinc merged 1 commit into
keycloak:release/26.6from
vaceksimon:backport-50550-26.6
Aug 6, 2026
Merged

Incorrect exact comparison when higher loa should be allowed#51392
rmartinc merged 1 commit into
keycloak:release/26.6from
vaceksimon:backport-50550-26.6

Conversation

@vaceksimon

@vaceksimon vaceksimon commented Aug 3, 2026 •
edited by ahus1
Loading

Copy link
Copy Markdown
Contributor

Closes #51391
Closes #50464

@rmartinc @vaceksimon
Incorrect exact comparison when higher loa should be allowed
4e95439 
Closes keycloak#50464

Signed-off-by: rmartinc <rmartinc@redhat.com>
Signed-off-by: Ricardo Martin <rmartinc@redhat.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
(cherry picked from commit 2537111)
@vaceksimon
vaceksimon requested review from a team as code owners August 3, 2026 10:49
@ahus1

ahus1 commented Aug 3, 2026

Copy link
Copy Markdown
Member

@vaceksimon - when backporting, always mention the original issue so that the automatic labelling will update the issue once it is merged.

FYI: As this PR will be merged to a branch, the task issue will not automatically closed; you will need to close it manually. Such task is technically not needed, unless you need it to track this for example internally.

@vaceksimon

vaceksimon commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@ahus1, thank you, I did not know that. Do we have any guidelines/doc on backporting?

@ahus1

ahus1 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Do we have any guidelines/doc on backporting?

@vaceksimon - here you go. Anything not in the docs is not needed.

keycloak/docs/bug-triage.md

Lines 96 to 106 in 59fc5b3

## Backporting
When triaging or fixing an issue, consider if the fix should be backported. If it should be backported add the
corresponding `backport/<release branch>` label.
For convenience, use the `.github/scripts/pr-backport.sh` to help create the backport PRs.
By adding a `backport/<release branch>` label to the issue it is automatically added to the patch release project, and
additionally when merging the PR the label `backport/<release branch>` is automatically replaced with a `release/x.y.z`
label.
Please do not add `release/x.y.z` manually!

rmartinc
rmartinc approved these changes Aug 3, 2026
View reviewed changes

@rmartinc rmartinc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vaceksimon! LGTM!

@rmartinc

rmartinc commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Yep @vaceksimon, when backporting do not create a new issue, just assign the backport label to the existing one and execute the script to send the PR to the correct branch. Thanks!

@rmartinc
rmartinc merged commit 13c323a into keycloak:release/26.6 Aug 6, 2026
82 checks passed
@vaceksimon
vaceksimon deleted the backport-50550-26.6 branch August 6, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmartinc rmartinc rmartinc approved these changes

Assignees

No one assigned

Labels

team/core-authn

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaceksimon @ahus1 @rmartinc