Skip to content

Updating OIDCAdvancedRequestParamsTest to the new test framework - #54718

Open
PadzerButch wants to merge 1 commit into
keycloak:mainfrom
PadzerButch:OIDCAdvancedRequestParamsTest_Branch
Open

PadzerButch wants to merge 1 commit into
keycloak:mainfrom
PadzerButch:OIDCAdvancedRequestParamsTest_Branch

Conversation

@PadzerButch

Copy link
Copy Markdown
Contributor

Closes #54602

@PadzerButch
PadzerButch force-pushed the OIDCAdvancedRequestParamsTest_Branch branch from 1b870e7 to d975ab6 Compare November 5, 2026 17:30
@PadzerButch
PadzerButch requested a balanced review from Copilot November 5, 2026 17:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Two migrated tests miss their intended checks: the client-ID mismatch case fails early with “Client not found,” and the no-request-URI case leaves the previous allowlist intact.

2 open issues
What changed in this PR

Migrates OIDCAdvancedRequestParamsTest from Arquillian to Keycloak’s new test framework, addressing #54602.

Changes:

  • Replaces legacy setup with injected resources and a per-method realm fixture.
  • Moves request-object serving and signing to HTTP-server and JWKS helpers.
  • Ports advanced OIDC parameter, claims, signature, and encryption tests and removes the legacy class.
File Description
testsuite/​integration-arquillian/​tests/​base/​src/​test/​java/​org/​keycloak/​testsuite/​oidc/​OIDCAdvancedRequestParamsTest.java Removes the legacy Arquillian test class.
tests/​base/​src/​test/​java/​org/​keycloak/​tests/​oidc/​OIDCAdvancedRequestParamsTest.java Adds the migrated tests, realm configuration, and request-object helpers.

Review effort: Balanced

@PadzerButch
PadzerButch force-pushed the OIDCAdvancedRequestParamsTest_Branch branch 2 times, most recently from 46cc4b3 to 4797867 Compare November 10, 2026 12:56
@PadzerButch
PadzerButch marked this pull request as ready for review November 10, 2026 12:56
@PadzerButch
PadzerButch requested review from a team as code owners November 10, 2026 12:56
Copilot AI balanced review requested due to automatic review settings November 10, 2026 12:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the migration of the advanced OIDC parameter tests to the new test framework.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@PadzerButch
PadzerButch force-pushed the OIDCAdvancedRequestParamsTest_Branch branch from 4797867 to 63c7b26 Compare November 10, 2026 16:27
Copilot AI balanced review requested due to automatic review settings November 10, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the migration of the advanced OIDC parameter tests to the new test framework.

No open issues 🎉

Review effort: Balanced

@PadzerButch
PadzerButch force-pushed the OIDCAdvancedRequestParamsTest_Branch branch from 63c7b26 to fdf90a5 Compare November 10, 2026 18:12
Copilot AI balanced review requested due to automatic review settings November 10, 2026 18:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the migration of the advanced OIDC parameter tests to the new framework.

No open issues 🎉

Review effort: Balanced

@lhanusov lhanusov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PadzerButch
Please, migrate the request-object functionality from TestingOIDCEndpointsApplicationResource into an OidcClientApplicationProvider, with a supplier and injection annotation, following the CimdProvider pattern. This would preserve the reusable functionality instead of moving it into private helpers in this test, and could avoid the custom PEM decoding by retaining direct access to the signing key.

@PadzerButch
PadzerButch force-pushed the OIDCAdvancedRequestParamsTest_Branch branch from fdf90a5 to 94e1dea Compare November 12, 2026 18:11
Copilot AI balanced review requested due to automatic review settings November 12, 2026 18:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new assertion expects Invalid Request when omitting client_id actually yields Missing parameters: client_id, causing the test to fail before the remaining scenarios run.

1 open issue

Review effort: Balanced

@PadzerButch
PadzerButch force-pushed the OIDCAdvancedRequestParamsTest_Branch branch from 94e1dea to f6bfc9d Compare November 13, 2026 12:11
Copilot AI balanced review requested due to automatic review settings November 13, 2026 12:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the OIDC test migration and reusable request-object support.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@PadzerButch
PadzerButch force-pushed the OIDCAdvancedRequestParamsTest_Branch branch from f6bfc9d to 8667993 Compare November 16, 2026 15:27
Copilot AI balanced review requested due to automatic review settings November 16, 2026 15:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new helper incorrectly expects Invalid Request when client_id is omitted, causing the first scenario to fail on the actual Missing parameters: client_id message and preventing subsequent checks from running.

No open issues 🎉

Review effort: Balanced

Closes keycloak#54602

Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
@PadzerButch
PadzerButch force-pushed the OIDCAdvancedRequestParamsTest_Branch branch from 8667993 to 8413524 Compare November 17, 2026 12:52
Copilot AI balanced review requested due to automatic review settings November 17, 2026 12:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The missing-client-ID assertion expects the wrong error message and blocks later cases, while the event assertion cannot detect LOGIN_ERROR events because that event type is not enabled.

1 open issue

Review effort: Balanced

public void promptNoneNotLogged() {
String expectedIssuer = oauth.doWellKnownRequest().getIssuer();

oauth.loginForm().prompt("none").open();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test Framework] Migrate OIDCAdvancedRequestParamsTest.java

3 participants