Repository navigation
Updating OIDCAdvancedRequestParamsTest to the new test framework - #54718
PadzerButch wants to merge 1 commit into
Conversation
1b870e7 to
d975ab6
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Two migrated tests miss their intended checks: the client-ID mismatch case fails early with “Client not found,” and the no-request-URI case leaves the previous allowlist intact.
2 open issues
What changed in this PR
Migrates OIDCAdvancedRequestParamsTest from Arquillian to Keycloak’s new test framework, addressing #54602.
Changes:
- Replaces legacy setup with injected resources and a per-method realm fixture.
- Moves request-object serving and signing to HTTP-server and JWKS helpers.
- Ports advanced OIDC parameter, claims, signature, and encryption tests and removes the legacy class.
| File | Description |
|---|---|
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oidc/OIDCAdvancedRequestParamsTest.java |
Removes the legacy Arquillian test class. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCAdvancedRequestParamsTest.java |
Adds the migrated tests, realm configuration, and request-object helpers. |
Review effort: Balanced
46cc4b3 to
4797867
Compare
4797867 to
63c7b26
Compare
63c7b26 to
fdf90a5
Compare
lhanusov
left a comment
There was a problem hiding this comment.
@PadzerButch
Please, migrate the request-object functionality from TestingOIDCEndpointsApplicationResource into an OidcClientApplicationProvider, with a supplier and injection annotation, following the CimdProvider pattern. This would preserve the reusable functionality instead of moving it into private helpers in this test, and could avoid the custom PEM decoding by retaining direct access to the signing key.
-
this will be the new location: https://github.com/keycloak/keycloak/tree/main/test-framework/oauth/src/main/java/org/keycloak/testframework/oauth
fdf90a5 to
94e1dea
Compare
94e1dea to
f6bfc9d
Compare
f6bfc9d to
8667993
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The new helper incorrectly expects Invalid Request when client_id is omitted, causing the first scenario to fail on the actual Missing parameters: client_id message and preventing subsequent checks from running.
No open issues 🎉
Review effort: Balanced
Closes keycloak#54602 Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
8667993 to
8413524
Compare
| public void promptNoneNotLogged() { | ||
| String expectedIssuer = oauth.doWellKnownRequest().getIssuer(); | ||
|
|
||
| oauth.loginForm().prompt("none").open(); |
Closes #54602