Skip to content

[Quarkus 4] Isolate expected migration constraint violations in separ… - #55446

Open
Pepo48 wants to merge 1 commit into
keycloak:mainfrom
Pepo48:issue-55445
Open

Pepo48 wants to merge 1 commit into
keycloak:mainfrom
Pepo48:issue-55445

Conversation

@Pepo48

@Pepo48 Pepo48 commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

…ate transactions

Closes: #55445

This can directly go to main.

…ate transactions

Closes: keycloak#55445

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
@Pepo48
Pepo48 requested review from a team as code owners November 21, 2026 23:11
Copilot AI lite review requested due to automatic review settings November 21, 2026 23:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review records no active issues, with the migration-test refactor separating setup, failure, verification, and cleanup transactions.

No open issues 🎉

What changed in this PR

This PR refactors migration model tests to isolate expected uniqueness constraint violations in separate transactions, enabling clean rollback and reliable verification of persisted state.

Changes:

  • Commits setup data before attempting duplicate migration writes.
  • Runs expected constraint violations in isolated transactions.
  • Verifies committed and rejected writes using fresh transactions.
  • Performs cleanup in dedicated transactions and reliably resets the test time offset.
File Description
testsuite/​model/​src/​test/​java/​org/​keycloak/​testsuite/​model/​MigrationModelTest.java Refactors migration constraint-violation tests to use isolated setup, failure, verification, and cleanup transactions.

Review effort: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Quarkus 4] Isolate expected migration constraint violations in separate transactions

2 participants