Repository navigation
Conversation
…ate transactions Closes: keycloak#55445 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review records no active issues, with the migration-test refactor separating setup, failure, verification, and cleanup transactions.
No open issues 🎉
What changed in this PR
This PR refactors migration model tests to isolate expected uniqueness constraint violations in separate transactions, enabling clean rollback and reliable verification of persisted state.
Changes:
- Commits setup data before attempting duplicate migration writes.
- Runs expected constraint violations in isolated transactions.
- Verifies committed and rejected writes using fresh transactions.
- Performs cleanup in dedicated transactions and reliably resets the test time offset.
| File | Description |
|---|---|
| testsuite/model/src/test/java/org/keycloak/testsuite/model/MigrationModelTest.java | Refactors migration constraint-violation tests to use isolated setup, failure, verification, and cleanup transactions. |
Review effort: Lite
17 of 29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ate transactions
Closes: #55445
This can directly go to main.