Repository navigation
Conversation
1 of 2 tasks
Closes keycloak#55241 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
ahus1
force-pushed
the
is-55241-flaky-organization-tests
branch
from
November 16, 2026 17:56
38ac172 to
0151c82
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.actions.TermsAndConditionsTest#termsAcceptedKeycloak CI - Forms IT (firefox) org.keycloak.testsuite.actions.TermsAndConditionsTest#termsDeclinedAccountKeycloak CI - Forms IT (firefox) |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the invitation-test synchronization changes.
No open issues 🎉
What changed in this PR
This PR addresses #55241 by making organization invitation tests wait for browser and server state instead of checking immediately after submission. The separate OrganizationSharedIdpBrokerTest failures remain out of scope.
Changes:
- Poll for the expected member count after registration and profile updates.
- Wait for membership creation or the update-profile page after broker login.
- Tolerate transient browser navigation errors when checking the page ID.
| File | Description |
|---|---|
tests/base/src/test/java/org/keycloak/tests/organization/admin/OrganizationInvitationTokenTest.java |
Adds polling helpers and navigation-error handling to reduce invitation-test timing failures. |
Review effort: Balanced
ahus1
marked this pull request as ready for review
November 16, 2026 18:58
ahus1
enabled auto-merge (squash)
November 16, 2026 18:58
vramik
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55241
The invitation tests read the member count and the current page right after a click, before the browser and the server had finished. They now poll for the expected state, with the Chrome-only
WebDriverExceptionduring navigation tolerated when checking for the update profile page.Decisions and assumptions
OrganizationSharedIdpBrokerTestis intentionally untouched. Its Chrome failures are not a submit-before-navigation race and are tracked separately in Flaky test: OrganizationSharedIdpBrokerTest is not redirected to the provider realm on Chrome #55243.OrganizationInvitationTokenTest: 4 of 4 tests pass in every run on headless Chrome and headless Firefox, where it failed on Chrome before.