Repository navigation
Conversation
… connection factory Closes keycloak#54539 Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com> Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> (cherry picked from commit 27ea6c9) Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Relates to keycloak#54539 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the backport adding custom-stack KEYCLOAK_JDBC_PING2 support.
No open issues 🎉
What changed in this PR
Backports custom-stack KEYCLOAK_JDBC_PING2 support to release/26.8, allowing XML-defined JGroups stacks to use Keycloak’s database connection factory while preserving UDP support.
Changes:
- Injects the connection factory and supplies default JDBC discovery properties without overriding explicit XML values.
- Rejects unsupported file-based and cross-site configurations, and narrows the in-JVM test-stack exemption.
- Adds custom TCP/UDP stack tests and changes a test protocol ID to avoid registration conflicts.
| File | Description |
|---|---|
| model/infinispan/src/test/java/org/keycloak/spi/infinispan/impl/embedded/JGroupsConfiguratorCustomStackTest.java | Tests injection, property defaults, UDP preservation, wrapper naming, and configuration guards. |
| model/infinispan/src/test/java/org/keycloak/jgroups/protocol/JdbcPing2Test.java | Uses a non-conflicting test protocol ID. |
| model/infinispan/src/main/java/org/keycloak/spi/infinispan/impl/embedded/JGroupsConfigurator.java | Adds custom-stack wrapping, shared JDBC defaults, and validation while retaining built-in TCP/UDP handling. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #54540 to release/26.8.
Closes #54539
Decisions and assumptions: the cherry-pick conflicted because 26.8 still has the UDP stacks that main removed, so the UDP handling is kept and the custom-stack code is merged alongside it. A second commit adds a unit test for a custom UDP stack, which only applies to this branch.