Isolated Processes 8: Remove dependency on nix#186
Merged
Conversation
74e8690 to
fc1f558
Compare
c1e6138 to
e2a1081
Compare
gabrielesvelto
approved these changes
Jun 10, 2026
gabrielesvelto
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left just a couple of nits.
e2a1081 to
524a78e
Compare
524a78e to
39a5b75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nixcrate is barely used now that all this stuff has been rewritten inlibc-- Let's deliver the final blow to it!This actually makes life a lot easier on the Firefox side of things, because auditing new versions of the
nixcrate is awful -- The entire thing is practically nothing butunsafecode, and we have to audit the entire crate even if we only use a handful of functions from it because our approval affects the safety of everyone who uses our whitelist oncargo vet.