Isolated Processes 12: Refactor Result, visiblity, wrappers - #200
Open
marti4d wants to merge 1 commit into
Open
Conversation
There are about to be a lot of methods returning Result<T, Error>, so let's just start using some specialized results to avoid repeating ourselves. Also, some of the visiblity on things could be cleaned up. And let's centralize some of the wrappers for things like FDs so the remote end can reuse them. There's not much to this, but it makes other reviews noisy so I thought it best to separate it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are about to be a lot of methods returning Result<T, Error>, so let's just start using some specialized results to avoid repeating ourselves.
Also, some of the visiblity on things could be cleaned up.
And let's centralize some of the wrappers for things like FDs so the remote end can reuse them.
There's not much to this, but it makes other reviews noisy so I thought it best to separate it out.